Skip to content

Conversation

@Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Jul 30, 2025

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Added onClick prop to NavTabs to support react-router 6 or higher due to component prop no longer existing causing href to not support it.

Also updated the examples from both Link and NavTab to work according to react-router-6 official implementation (even though we are mocking the functionality).

Closes
OC-18635

@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Jul 30, 2025

I want to create a basic vite application to do an actual test using react-router-6 to make sure that it works as intended.

@Mil4n0r Mil4n0r marked this pull request as ready for review August 1, 2025 11:43
@Jialecl Jialecl self-requested a review August 4, 2025 12:14
@Jialecl Jialecl self-assigned this Aug 4, 2025
@Jialecl Jialecl merged commit 29786fc into master Aug 6, 2025
4 checks passed
@Jialecl Jialecl deleted the Mil4n0r/fix_navtabs_router branch August 6, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants