Skip to content

Fix Paginator buttons to support localization #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mil4n0r merged 1 commit into from
Jul 11, 2025
Merged

Fix Paginator buttons to support localization #2255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions apps/website/screens/principles/localization/LocalizationPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,30 @@ const sections = [
with those parameters.
</td>
</tr>
<tr>
<td>
<Code>firstResultsTitle</Code>
</td>
<td>First results</td>
</tr>
<tr>
<td>
<Code>previousResultsTitle</Code>
</td>
<td>Previous results</td>
</tr>
<tr>
<td>
<Code>nextResultsTitle</Code>
</td>
<td>Next results</td>
</tr>
<tr>
<td>
<Code>lastResultsTitle</Code>
</td>
<td>Last results</td>
</tr>
</tbody>
</DxcTable>
),
Expand Down
6 changes: 5 additions & 1 deletion packages/lib/src/common/variables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1504,6 +1504,10 @@ export const defaultTranslatedComponentLabels = {
`${minNumberOfItems} to ${maxNumberOfItems} of ${totalItems}`,
goToPageText: "Go to page:",
pageOfText: (pageNumber: number, totalPagesNumber: number) => `Page: ${pageNumber} of ${totalPagesNumber}`,
firstResultsTitle: "First results",
previousResultsTitle: "Previous results",
nextResultsTitle: "Next results",
lastResultsTitle: "Last results",
},
passwordInput: {
inputShowPasswordTitle: "Show password",
Expand All @@ -1519,7 +1523,7 @@ export const defaultTranslatedComponentLabels = {
actionClearSelectionTitle: "Clear selection",
actionClearSearchTitle: "Clear search",
noMatchesErrorMessage: "No matches found",
selectAllLabel: "Select all"
selectAllLabel: "Select all",
},
tabs: {
scrollLeft: "Scroll left",
Expand Down
8 changes: 4 additions & 4 deletions packages/lib/src/paginator/Paginator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ const DxcPaginator = ({
onClick={() => {
onPageChange(1);
}}
title="First results"
title={translatedLabels.paginator.firstResultsTitle}
size={{ height: "medium" }}
/>

Expand All @@ -121,7 +121,7 @@ const DxcPaginator = ({
onClick={() => {
onPageChange(currentPage - 1);
}}
title="Previous results"
title={translatedLabels.paginator.previousResultsTitle}
size={{ height: "medium" }}
/>
</ButtonsContainer>
Expand Down Expand Up @@ -157,7 +157,7 @@ const DxcPaginator = ({
onClick={() => {
onPageChange(currentPage + 1);
}}
title="Next results"
title={translatedLabels.paginator.nextResultsTitle}
size={{ height: "medium" }}
/>
<DxcButton
Expand All @@ -168,7 +168,7 @@ const DxcPaginator = ({
onClick={() => {
onPageChange(totalPages);
}}
title="Last results"
title={translatedLabels.paginator.lastResultsTitle}
size={{ height: "medium" }}
/>
</ButtonsContainer>
Expand Down