Skip to content

Conversation

@Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented May 30, 2025

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

The condition to not display the paginator even though hidePaginator was not set was incomplete, as it was not taking into account the possibility to change the number of items.

p.e. Let's say we have a 12 items dataset, where we have [5, 10, 15] as itemsPerPageOptions.

Previously, if we switched to 15, due to 15 being higher than 12, the paginator would be hidden and not able to change back to the 5 or 10 options displayed.

Now, we take all of the options into account and only hide it in case all of the options are higher than the total count of items.

@Mil4n0r Mil4n0r marked this pull request as draft May 30, 2025 12:51
@Mil4n0r Mil4n0r marked this pull request as ready for review June 2, 2025 06:44
@Jialecl Jialecl self-requested a review June 18, 2025 08:29
@Jialecl Jialecl self-assigned this Jun 18, 2025
@Jialecl Jialecl merged commit 99ee508 into master Jun 18, 2025
4 checks passed
@Jialecl Jialecl deleted the fix_paginator_display branch June 18, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants