Skip to content

Conversation

@Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented May 12, 2025

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
Gap value changed to --spacing-gap-xxl.

@Mil4n0r Mil4n0r self-assigned this May 12, 2025
@Mil4n0r Mil4n0r self-requested a review May 12, 2025 14:38
Copy link
Collaborator

@Mil4n0r Mil4n0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes that you did are correct, however there are 2 files in which you have to add xxl > xl in the first DxcFlex:

  • apps/website/screen/principles/typography/TypographyPageLayout
  • apps/website/screen/principles/iconography/IconographyPage

That's all.

@Mil4n0r Mil4n0r merged commit a7dd236 into master May 14, 2025
1 check passed
@Mil4n0r Mil4n0r deleted the jialecl-doc-spacing branch May 14, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants