-
Notifications
You must be signed in to change notification settings - Fork 17
Heading redesign #2214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heading redesign #2214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a redesign of the heading component to align with the new design kit specifications and token architecture. Key changes include:
- Removal of the explicit "bold" weight from DxcHeading instances across multiple pages.
- Updated heading level handling to support level 6 where applicable.
- Adjustments to code examples and documentation to reflect the new heading API.
Reviewed Changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/website/screens/principles/iconography/IconographyPage.tsx | Removed the explicit bold weight from the Iconography heading. |
| apps/website/screens/principles/data-visualization/DataVisualizationPage.tsx | Removed the bold weight from the Data visualization heading. |
| apps/website/screens/principles/color/ColorPage.tsx | Removed the bold weight from the Color heading. |
| apps/website/screens/overview/releases/ReleasesPage.tsx | Removed the bold weight from the Releases heading. |
| apps/website/screens/overview/introduction/IntroductionPage.tsx | Removed the bold weight from the Introduction heading. |
| apps/website/screens/overview/installation/InstallationPage.tsx | Removed the bold weight from the Installation heading. |
| apps/website/screens/overview/component-lifecycle/ComponentLifecyclePage.tsx | Removed the bold weight from the Component lifecycle heading. |
| apps/website/screens/components/heading/code/examples/basicUsage.ts | Updated code example to illustrate multiple heading levels. |
| apps/website/screens/components/heading/code/HeadingCodePage.tsx | Updated the prop documentation for "level", "as", "margin", and "weight" to include support for level 6 and revised allowed values. |
| apps/website/screens/components/heading/HeadingPageLayout.tsx | Revised heading description to be more concise and consistent with the new design. |
| apps/website/screens/common/HeadingLink.tsx | Removed the explicit bold weight from the heading rendered within the link component. |
| apps/website/screens/common/ComponentHeading.tsx | Removed the explicit bold weight from the component heading in favor of the new default styling. |
| apps/website/pages/components/heading/index.tsx | Updated to use the new HeadingOverviewPage instead of the previous code/spec pages. |
Comments suppressed due to low confidence (1)
apps/website/screens/common/ComponentHeading.tsx:7
- The explicit 'bold' weight was removed from the ComponentHeading. Verify that the default styling now applied meets the intended design specifications for visual hierarchy.
<DxcHeading level={1} text={name} />
Checklist
/libdirectory./websiteas needed.Description
Redesign of the heading component following the new design kit specifications, already using the new token architecture (CSS variables). Some changes have been made to the component:
h6and6.Breaking changes
weightvalues have changed:'default' | 'regular' | 'light'.Additional context
Figma designs