Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Apr 16, 2025

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
New design tokens added to Halstack:

  • Core:
    • New: --font-size-40: 40px;.
  • Alias:
    • Changed --spacing-gap-xl value from the core --dimensions-48 to --dimensions-32.
    • New: --spacing-gap-xxl: var(--dimensions-48);.
    • New: --typography-heading-xxl: var(--font-size-40);.
    • New: --typography-heading-light: var(--font-weight-light);.
    • New: --typography-heading-regular: var(--font-weight-regular);.
    • New: --typography-link-m: var(--font-size-14);.
    • New: --typography-link-regular: var(--font-weight-regular);.

This has affected several places and components (Link and Paginator).

Additional context
Figma

@GomezIvann GomezIvann requested a review from Copilot April 16, 2025 08:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • packages/lib/src/styles/variables.css: Language not supported

@GomezIvann GomezIvann marked this pull request as ready for review April 16, 2025 09:37
@Jialecl Jialecl self-requested a review April 16, 2025 09:39
@Jialecl Jialecl self-assigned this Apr 16, 2025
@Jialecl Jialecl merged commit 9410524 into master Apr 16, 2025
5 checks passed
@Jialecl Jialecl deleted the gomezivann/design-tokens-update branch April 16, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants