Skip to content

Nav tab fixes and doc updates #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GomezIvann merged 10 commits into from
Apr 15, 2025
Merged

Nav tab fixes and doc updates #2211

GomezIvann merged 10 commits into from
Apr 15, 2025

Conversation

@Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented Apr 11, 2025 •
edited by GomezIvann
Loading

Checklist

  • The build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description

  • Documentation updates:
    • New best practice for the Tabs and Nav tabs regarding icon usage.
    • Tabs best practices restructured to match the format from other components.
    • Small typos fixed.
  • Nav tabs iconPosition prop default changed from 'top' to 'left', as in the Tabs.
  • Fixed bug with the outline and with the active tab underline.

@Jialecl Jialecl changed the title Tab outline offset hotfix Tab outline offset fix Apr 11, 2025
@GomezIvann GomezIvann self-requested a review April 11, 2025 10:39
@GomezIvann GomezIvann self-assigned this Apr 11, 2025
@GomezIvann GomezIvann changed the title Tab outline offset fix Nav tab fixes and doc updates Apr 11, 2025
GomezIvann
GomezIvann previously approved these changes Apr 11, 2025
View reviewed changes
Jialecl
Jialecl commented Apr 14, 2025
View reviewed changes
Jialecl
Jialecl commented Apr 14, 2025
View reviewed changes
@GomezIvann GomezIvann merged commit 11075fb into master Apr 15, 2025
4 checks passed
@GomezIvann GomezIvann deleted the jialecl-navtab-offset branch April 15, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GomezIvann GomezIvann GomezIvann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GomezIvann GomezIvann

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jialecl @GomezIvann