Table and resultset table redesigns #2208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GomezIvann
changed the title
Contributor
There was a problem hiding this comment.
Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/lib/src/data-grid/DataGrid.stories.tsx:32
- Consider explicitly typing the 'value' parameter (for example, as value?: string) in the onClick handler for consistency with similar changes in other parts of the code.
onClick: (value?) => {
Mil4n0r
approved these changes
May 15, 2025
Collaborator
|
Missing doc. Will have to create a separate PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
Redesign of both the resultset table and the regular table components, following the new design kit specifications, already using the new token architecture (CSS variables).
Doc missing!
Additional context
Figma designs
Closes #1735