Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Mar 21, 2025

Checklist

  • The build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description

@GomezIvann GomezIvann changed the title Gomezivann/halstack site updates design tokens Halstack site updates based on the new design tokens Mar 21, 2025
@GomezIvann GomezIvann requested a review from Copilot April 11, 2025 10:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 189 out of 189 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

apps/website/pages/components/divider/code.tsx:9

  • [nitpick] Consider using consistent title casing across pages (for example, 'Divider Code' vs 'Divider code') to maintain uniformity in the UI.
<title>Divider code — Halstack Design System</title>

@GomezIvann GomezIvann requested a review from Copilot April 15, 2025 12:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Halstack website to reflect the new design tokens and removes outdated theme pages.

  • Removed the deprecated /themes page and associated code.
  • Refactored several page components to use implicit return arrow functions.
  • Updated document titles and adjusted layout components in the main app.

Reviewed Changes

Copilot reviewed 311 out of 311 changed files in this pull request and generated no comments.

Show a summary per file
File Description
apps/website/pages/principles/typography/index.tsx Converted component to implicit return and updated layout.
apps/website/pages/principles/themes.tsx Removed the deprecated themes page.
apps/website/pages/principles/spacing.tsx Refactored to use an implicit return arrow function.
apps/website/pages/principles/localization.tsx Refactored to use an implicit return arrow function.
apps/website/pages/principles/layout.tsx Simplified component structure with implicit return.
apps/website/pages/principles/iconography.tsx Refactored component structure with implicit return.
apps/website/pages/principles/data-visualization.tsx Converted to use implicit return and cleaned up layout.
apps/website/pages/principles/color.tsx Refactored component and updated document title.
apps/website/pages/overview/releases.tsx Simplified component structure with minor type adjustments.
apps/website/pages/overview/introduction.tsx Refactored to use an implicit return arrow function.
apps/website/pages/overview/installation.tsx Streamlined component to use an implicit return.
apps/website/pages/overview/component-lifecycle.tsx Converted to implicit return arrow function.
apps/website/pages/components/divider/index.tsx Refactored and updated component structure.
apps/website/pages/components/divider/code.tsx Updated document title and simplified component structure.
apps/website/pages/components/contextual-menu/index.tsx Renamed component for consistency and refactored structure.
apps/website/pages/components/contextual-menu/code.tsx Updated document title and refactored component structure.
apps/website/pages/components/button/code.tsx Updated document title and refactored component structure.
apps/website/pages/components/alert/index.tsx Refactored component to use implicit return.
apps/website/pages/components/alert/code.tsx Updated document title and refactored component structure.
apps/website/pages/_app.tsx Removed unused providers and wrappers; updated layout logic.

@GomezIvann GomezIvann marked this pull request as ready for review May 7, 2025 09:03
Copy link
Collaborator

@Mil4n0r Mil4n0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple appearances (192) in which you are using:
DxcInset space="var(--spacing-gap-...)
For space, we should be using spacing padding instead for these cases

@Mil4n0r Mil4n0r self-assigned this May 7, 2025
Copy link
Collaborator

@Mil4n0r Mil4n0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, there are still some appearances where "4rem" is being applied to the gap inside DxcFlex, should we change them to --spacing-gap-xxl or asking the designers to add additional alias for it to match the 64px value?

@GomezIvann
Copy link
Collaborator Author

By the way, there are still some appearances where "4rem" is being applied to the gap inside DxcFlex, should we change them to --spacing-gap-xxl or asking the designers to add additional alias for it to match the 64px value?

I will ask for feedback to the designers.

@Mil4n0r
Copy link
Collaborator

Mil4n0r commented May 8, 2025

By the way, there are still some appearances where "4rem" is being applied to the gap inside DxcFlex, should we change them to --spacing-gap-xxl or asking the designers to add additional alias for it to match the 64px value?

I will ask for feedback to the designers.

We are going to keep it as it is, because it is a specific use case.

@Mil4n0r Mil4n0r self-requested a review May 8, 2025 10:03
@Mil4n0r Mil4n0r merged commit 0da934f into master May 8, 2025
1 check passed
@Mil4n0r Mil4n0r deleted the gomezivann/halstack-site-updates-design-tokens branch May 8, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants