Toast redesign #2179
Merged
Toast redesign #2179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mil4n0r
requested changes
Mar 26, 2025
Mil4n0r
requested changes
Apr 4, 2025
apps/website/screens/components/toast/overview/ToastOverviewPage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/toast/overview/ToastOverviewPage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/toast/overview/ToastOverviewPage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/toast/overview/ToastOverviewPage.tsx
Outdated
Show resolved
Hide resolved
Mil4n0r
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
Redesign of the toast component following the new design kit specifications, already using the new token architecture (CSS variables). Also, some code refactors are included in the component to enhance its performance and code readability.
inhertitColorprop for theDxcSpinnercomponent. "If true, the color is inherited from the closest parent with a defined color. This allows users to adapt the spinner to the semantic color of the use case in which it is used."Additional context
Figma designs