-
Notifications
You must be signed in to change notification settings - Fork 17
Tabs redesign #2178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs redesign #2178
Conversation
apps/website/screens/components/tabs/overview/TabsOverviewPage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/tabs/overview/TabsOverviewPage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/tabs/overview/TabsOverviewPage.tsx
Outdated
Show resolved
Hide resolved
Mil4n0r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I forgot to add something, in the focused tabs example, the focus outline doesn't match what is expected from the component (the bottom outline is not properly shown due to overlapping with the border from the <Underline> component)
Mmmmm, I think in the designs it is like that: Check it too if I'm wrong! |
It is currently overlapping with the Underline, we have to discuss with the designers what the expected behavior is. The rest is perfect now! |


Checklist
/libdirectory./websiteas needed.Description
Redesign of the tabs component following the new design kit specifications, already using the new token architecture (CSS variables). Also, some code refactors and improvements are included in the components to enhance its performance and code readability. The legacy props have changed to deprecated status.
Additional context
Figma designs