Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Mar 6, 2025

Checklist

  • The build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Redesign of the tabs component following the new design kit specifications, already using the new token architecture (CSS variables). Also, some code refactors and improvements are included in the components to enhance its performance and code readability. The legacy props have changed to deprecated status.

Additional context
Figma designs

@GomezIvann GomezIvann marked this pull request as draft March 6, 2025 11:47
@GomezIvann GomezIvann marked this pull request as ready for review March 6, 2025 13:39
@GomezIvann GomezIvann marked this pull request as draft March 19, 2025 10:42
@GomezIvann GomezIvann marked this pull request as ready for review March 20, 2025 13:18
@Mil4n0r Mil4n0r self-assigned this Mar 24, 2025
@Mil4n0r Mil4n0r self-requested a review March 24, 2025 08:48
Copy link
Collaborator

@Mil4n0r Mil4n0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I forgot to add something, in the focused tabs example, the focus outline doesn't match what is expected from the component (the bottom outline is not properly shown due to overlapping with the border from the <Underline> component)

@GomezIvann
Copy link
Collaborator Author

Oh I forgot to add something, in the focused tabs example, the focus outline doesn't match what is expected from the component (the bottom outline is not properly shown due to overlapping with the border from the <Underline> component)

Mmmmm, I think in the designs it is like that:

image

Check it too if I'm wrong!

@Mil4n0r
Copy link
Collaborator

Mil4n0r commented Mar 26, 2025

Oh I forgot to add something, in the focused tabs example, the focus outline doesn't match what is expected from the component (the bottom outline is not properly shown due to overlapping with the border from the <Underline> component)

Mmmmm, I think in the designs it is like that:

image

Check it too if I'm wrong!

It is currently overlapping with the Underline, we have to discuss with the designers what the expected behavior is.

The rest is perfect now!

@Mil4n0r Mil4n0r self-requested a review March 28, 2025 10:50
@Mil4n0r Mil4n0r merged commit 6d9e5bd into master Mar 28, 2025
4 checks passed
@Mil4n0r Mil4n0r deleted the gomezivann/tabs-redesign branch March 28, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants