Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Feb 18, 2025

Checklist

  • The build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Redesign of the slider component following the new design kit specifications, already using the new token architecture (CSS variables). This PR also includes:

  • Rounding-up issues are fixed when there's a defined step, minimum, and maximum values. The value allows "invalid" numbers, but the component always renders consistently.
  • Now the component supports negative limits and the slider can set values between them (the slider couldn't go under 0 values, event with a negative minimum).
  • Now the component supports decimal values, limits and steps.
  • The component now uses the Number Input internal, which improves both the implementation (only numbers) and the behaviour of the component (mouse wheel increase/decrease).
  • Other code improvements and refactors for a better understanding of its behavior.

Additional context

Closes #841

@GomezIvann GomezIvann marked this pull request as ready for review February 20, 2025 12:28
@Mil4n0r Mil4n0r self-requested a review February 21, 2025 13:03
@Mil4n0r Mil4n0r self-assigned this Feb 21, 2025
@GomezIvann GomezIvann marked this pull request as draft February 25, 2025 09:27
@GomezIvann GomezIvann marked this pull request as ready for review February 26, 2025 13:40
@Mil4n0r
Copy link
Collaborator

Mil4n0r commented Feb 28, 2025

Only missing doc, everything seems okay

@Mil4n0r Mil4n0r merged commit f2ee373 into master Mar 18, 2025
4 of 5 checks passed
@Mil4n0r Mil4n0r deleted the gomezivann/tokens-slider branch March 18, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Component redesign: Slider

3 participants