-
Notifications
You must be signed in to change notification settings - Fork 17
Dropdown redesign #2161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Dropdown redesign #2161
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
75b7bb0
Reimplementation of the Dropdown component with new CSS variables
31597e9
Fixed problem with hover
644f814
Fixed color for background
27a1dab
Fixed border-radius based on latest visual updates
57511e4
Added documentation with the new structure
96a960e
Uncommented variables css import
79b3b57
Fixed some problems in dropdown refactor
dfa6960
Removed return statement
4db9a50
Fixed some problems in dropdown menu item refactor
76dde70
Minor fixes and removing opinionated theme
515352c
Solved styles and doc problems
05e0d72
Improved code for dropdown icon position
08903d0
Merge branch 'master' into Mil4n0r/tokens-dropdown
Mil4n0r 3afea43
Fixed problem with long texts and paddings
20ff381
Merge branch 'Mil4n0r/tokens-dropdown' of github.com:dxc-technology/h…
64061fd
Minor fixes from review
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import Head from "next/head"; | ||
| import type { ReactElement } from "react"; | ||
| import DropdownPageLayout from "screens/components/dropdown/DropdownPageLayout"; | ||
| import DropdownCodePage from "screens/components/dropdown/code/DropdownCodePage"; | ||
|
|
||
| const Code = () => { | ||
| return ( | ||
| <> | ||
| <Head> | ||
| <title>Dropdown Code — Halstack Design System</title> | ||
| </Head> | ||
| <DropdownCodePage /> | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| Code.getLayout = (page: ReactElement) => <DropdownPageLayout>{page}</DropdownPageLayout>; | ||
|
|
||
| export default Code; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,19 @@ | ||
| import Head from "next/head"; | ||
| import type { ReactElement } from "react"; | ||
| import DropdownPageLayout from "screens/components/dropdown/DropdownPageLayout"; | ||
| import DropdownCodePage from "screens/components/dropdown/code/DropdownCodePage"; | ||
| import DropdownOverviewPage from "screens/components/dropdown/overview/DropdownOverviewPage"; | ||
|
|
||
| const Index = () => { | ||
| return ( | ||
| <> | ||
| <Head> | ||
| <title>Dropdown — Halstack Design System</title> | ||
| </Head> | ||
| <DropdownCodePage></DropdownCodePage> | ||
| <DropdownOverviewPage /> | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| Index.getLayout = function getLayout(page: ReactElement) { | ||
| return <DropdownPageLayout>{page}</DropdownPageLayout>; | ||
| }; | ||
| Index.getLayout = (page: ReactElement) => <DropdownPageLayout>{page}</DropdownPageLayout>; | ||
|
|
||
| export default Index; |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.