Dialog redesign #2159
Merged
Dialog redesign #2159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GomezIvann
suggested changes
Mar 4, 2025
GomezIvann
suggested changes
Mar 4, 2025
apps/website/screens/components/dialog/overview/DialogOverviewPage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/dialog/overview/DialogOverviewPage.tsx
Outdated
Show resolved
Hide resolved
added 2 commits
March 10, 2025 12:59
GomezIvann
suggested changes
Mar 12, 2025
Collaborator
GomezIvann
left a comment
GomezIvann
left a comment
There was a problem hiding this comment.
Just one thing, remove the HalstackProvider from the stories of the dialog!
apps/website/screens/components/dialog/overview/DialogOverviewPage.tsx
Outdated
Show resolved
Hide resolved
GomezIvann
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
Redesign of the dialog component following the new design kit specifications, already using the new token architecture (CSS variables).
Additional context