Refactor Accordion component #2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GomezIvann
suggested changes
Feb 19, 2025
apps/website/screens/components/accordion/AccordionPageLayout.tsx
Outdated
Show resolved
Hide resolved
GomezIvann
reviewed
Feb 25, 2025
apps/website/screens/components/accordion/usage/images/accordion_content.png
Show resolved
Hide resolved
apps/website/screens/components/accordion/code/AccordionCodePage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/accordion/code/AccordionCodePage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/accordion/code/AccordionCodePage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/accordion/code/examples/disabledAccordions.ts
Outdated
Show resolved
Hide resolved
apps/website/screens/components/accordion/usage/AccordionUsagePage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/accordion/usage/AccordionUsagePage.tsx
Outdated
Show resolved
Hide resolved
GomezIvann
reviewed
Feb 25, 2025
GomezIvann
reviewed
Feb 26, 2025
Collaborator
GomezIvann
left a comment
GomezIvann
left a comment
There was a problem hiding this comment.
When we have the new images I will merge the PR!
GomezIvann
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
Refactor Accordion component based on new design: https://www.figma.com/design/7CanVB5tlgwOeDIlvK8Dyf/Component-exploration-%26-Testing?node-id=1712-4101&m=dev
DxcAccordionGrouphas been removed and now we have only one component:DxcAccordion. This component acts like the old accordion group, with accordion items inside.Several changes:
disabledis now configurable on each accordion item, instead of in the accordion parent (old Accordion group).subLabeladdedindependentadded. This specifies when only one accordion can be expanded or several.