File Input redesign #2156
Merged
File Input redesign #2156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mil4n0r
requested changes
Feb 7, 2025
…eact into jialecl-fileInput-tokens
Mil4n0r
requested changes
Feb 27, 2025
Mil4n0r
requested changes
Mar 18, 2025
Mil4n0r
requested changes
Mar 25, 2025
Collaborator
|
Only missing doc. |
Mil4n0r
requested changes
Apr 23, 2025
Collaborator
Mil4n0r
left a comment
Mil4n0r
left a comment
There was a problem hiding this comment.
Great job Jiale!
The only thing that I wanted to point out is that, now that we display the error message in one single line, it would be interesting to display a Tooltip if we hover a text with ellipsis, the same way that we do for other components such as Spinner, Select, etc.
This is easily achievable by using the TooltipWrapper with its condition prop (there are multiple examples in the code). Also, don't forget to add a storybook action to hover the text and display the tooltip.
…hnology/halstack-react into jialecl-fileInput-tokens
…halstack-react into jialecl-fileInput-tokens
…hnology/halstack-react into jialecl-fileInput-tokens
Mil4n0r
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Description
Redesign of the fileInput component following the new design kit specifications, already using the new token architecture (CSS variables).
Additional context