Skip to content

Select redesign #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mil4n0r merged 19 commits into from
Mar 12, 2025
Merged

Select redesign #2154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c413fdf
Select reimplemented with new tokens
GomezIvann Feb 6, 2025
05a72ed
More styling updates to the Select
GomezIvann Feb 6, 2025
589eda9
Testing updates Select
GomezIvann Feb 7, 2025
029c436
Fixed Select tests
GomezIvann Feb 7, 2025
dfda12e
More fixes to the Select accessibility
GomezIvann Feb 7, 2025
f8465c2
preview updates
GomezIvann Feb 10, 2025
78a1d7b
More select updates and fixes
GomezIvann Feb 11, 2025
8e56b0a
Merge branch 'master' into gomezivann/select-reimplementation
GomezIvann Feb 11, 2025
6694bf8
Updates based on feedback from the designers
GomezIvann Feb 11, 2025
5cfd465
Select updates
GomezIvann Feb 17, 2025
5be57f8
Merge branch 'master' into gomezivann/select-reimplementation
GomezIvann Feb 28, 2025
666b76a
Updates based on feedback
GomezIvann Feb 28, 2025
d975717
Select documentation
GomezIvann Feb 28, 2025
f4b693d
Alphabetically sorted props
GomezIvann Mar 3, 2025
01f6dbc
Corrected alphabetically sorted props
GomezIvann Mar 3, 2025
42dd985
Merge branch 'master' into gomezivann/select-reimplementation
Mil4n0r Mar 10, 2025
94ae672
Select updates based on feedback
GomezIvann Mar 12, 2025
2921c74
Closing tags
GomezIvann Mar 12, 2025
83fc1f9
Merge branch 'master' into gomezivann/select-reimplementation
Mil4n0r Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions apps/website/pages/components/select/code.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import Head from "next/head";
import type { ReactElement } from "react";
import SelectPageLayout from "screens/components/select/SelectPageLayout";
import SelectCodePage from "screens/components/select/code/SelectCodePage";

const Code = () => (
<>
<Head>
<title>Select code — Halstack Design System</title>
</Head>
<SelectCodePage />
</>
);

Code.getLayout = (page: ReactElement) => <SelectPageLayout>{page}</SelectPageLayout>;

export default Code;
24 changes: 10 additions & 14 deletions apps/website/pages/components/select/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,17 @@
import Head from "next/head";
import type { ReactElement } from "react";
import SelectPageLayout from "screens/components/select/SelectPageLayout";
import SelectCodePage from "screens/components/select/code/SelectCodePage";
import SelectOverviewPage from "screens/components/select/overview/SelectOverviewPage";

const Index = () => {
return (
<>
<Head>
<title>Select — Halstack Design System</title>
</Head>
<SelectCodePage></SelectCodePage>
</>
);
};
const Index = () => (
<>
<Head>
<title>Select — Halstack Design System</title>
</Head>
<SelectOverviewPage />
</>
);

Index.getLayout = function getLayout(page: ReactElement) {
return <SelectPageLayout>{page}</SelectPageLayout>;
};
Index.getLayout = (page: ReactElement) => <SelectPageLayout>{page}</SelectPageLayout>;

export default Index;
21 changes: 0 additions & 21 deletions apps/website/pages/components/select/specifications.tsx
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions apps/website/pages/components/select/usage.tsx
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions apps/website/screens/components/select/SelectPageLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ import { ReactNode } from "react";

const SelectPageHeading = ({ children }: { children: ReactNode }) => {
const tabs = [
{ label: "Code", path: "/components/select" },
{ label: "Usage", path: "/components/select/usage" },
{ label: "Specifications", path: "/components/select/specifications" },
{ label: "Overview", path: "/components/select" },
{ label: "Code", path: "/components/select/code" },
];

return (
Expand All @@ -19,7 +18,7 @@ const SelectPageHeading = ({ children }: { children: ReactNode }) => {
<DxcParagraph>
The select component allows users to make single or multiple selections from a pre-defined list of options.
</DxcParagraph>
<TabsPageHeading tabs={tabs}></TabsPageHeading>
<TabsPageHeading tabs={tabs} />
</DxcFlex>
</PageHeading>
{children}
Expand Down
Loading