-
Notifications
You must be signed in to change notification settings - Fork 17
Chip redesign #2153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chip redesign #2153
Conversation
|
Missing documentation. @GomezIvann Regarding your comments, I agree we should take a look at the API of the component, however I would personally leave that for once we finish reimplementing the rest of the components using tokens. Please let me know what you think about it. Otherwise I can spend a bit more time and refactor the component if it is not something huge. |
Agree on the API review, but the use of the Action Icon I think should be considered since it is been used in the designs: |
|
Okay, I will look into it. |
|
Already added! Please take a look at it. |
|
Looks perfect! Only the doc remains. |
…ack-react into Mil4n0r/tokens-chip
|
Added doc. I am aware that we are still using "Prefix action" and "Suffix action" as default texts for the ActionIcons that are used inside of the component. We should probably make some slight improvements for the API to handle this. For example: title: { prefix: string, suffix: string } Or something similar. EDIT: I have created a new issue regarding this topic: #2188 |
apps/website/screens/components/chip/overview/ChipOverviewPage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/chip/overview/examples/categorization.ts
Outdated
Show resolved
Hide resolved
apps/website/screens/components/chip/overview/ChipOverviewPage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/chip/overview/ChipOverviewPage.tsx
Outdated
Show resolved
Hide resolved
…ack-react into Mil4n0r/tokens-chip
|
I had accidentally modified the Container story, the change is now reverted sorry about that. |

Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Description
Redesign of the chip component following the new design kit specifications, already using the new token architecture (CSS variables).
Additional context