Skip to content

Conversation

@Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Feb 5, 2025

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Redesign of the chip component following the new design kit specifications, already using the new token architecture (CSS variables).

Additional context

@GomezIvann GomezIvann self-requested a review February 10, 2025 12:59
@GomezIvann GomezIvann self-assigned this Feb 10, 2025
@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Feb 19, 2025

Missing documentation.

@GomezIvann Regarding your comments, I agree we should take a look at the API of the component, however I would personally leave that for once we finish reimplementing the rest of the components using tokens. Please let me know what you think about it. Otherwise I can spend a bit more time and refactor the component if it is not something huge.

@GomezIvann
Copy link
Collaborator

Missing documentation.

@GomezIvann Regarding your comments, I agree we should take a look at the API of the component, however I would personally leave that for once we finish reimplementing the rest of the components using tokens. Please let me know what you think about it. Otherwise I can spend a bit more time and refactor the component if it is not something huge.

Agree on the API review, but the use of the Action Icon I think should be considered since it is been used in the designs:

image

@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Feb 28, 2025

Okay, I will look into it.

@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Feb 28, 2025

Already added! Please take a look at it.

@GomezIvann
Copy link
Collaborator

GomezIvann commented Mar 3, 2025

Looks perfect! Only the doc remains.

@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Mar 13, 2025

Added doc. I am aware that we are still using "Prefix action" and "Suffix action" as default texts for the ActionIcons that are used inside of the component. We should probably make some slight improvements for the API to handle this. For example:

title: { prefix: string, suffix: string }

Or something similar.

EDIT: I have created a new issue regarding this topic: #2188

GomezIvann
GomezIvann previously approved these changes Mar 13, 2025
GomezIvann
GomezIvann previously approved these changes Mar 13, 2025
@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Mar 13, 2025

I had accidentally modified the Container story, the change is now reverted sorry about that.

@Jialecl Jialecl merged commit 646cad5 into master Mar 14, 2025
4 checks passed
@Jialecl Jialecl deleted the Mil4n0r/tokens-chip branch March 14, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants