Skip to content

Global styles for Halstack library #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jialecl merged 6 commits into from
Jan 30, 2025
Merged

Global styles for Halstack library #2149

Jialecl merged 6 commits into from
Jan 30, 2025

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Jan 29, 2025 •
edited
Loading

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description

  • New variables.css file and fonts.css, inside a folder /styles.
  • Updated storybook preview configuration to use these files.
  • Updated library entry point index.ts.

@GomezIvann GomezIvann marked this pull request as ready for review January 29, 2025 12:14
@Jialecl Jialecl self-requested a review January 29, 2025 13:08
@Jialecl Jialecl self-assigned this Jan 29, 2025
@Jialecl Jialecl merged commit 8db6a95 into master Jan 30, 2025
4 checks passed
@Jialecl Jialecl deleted the gomezivann/global-styles branch January 30, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jialecl Jialecl Jialecl approved these changes

Assignees

@Jialecl Jialecl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GomezIvann @Jialecl