Skip to content

ariaLabel prop added to select component #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GomezIvann merged 2 commits into from
Jan 15, 2025
Merged

ariaLabel prop added to select component #2142

GomezIvann merged 2 commits into from
Jan 15, 2025

Conversation

@Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented Jan 14, 2025 •
edited
Loading

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
ariaLabel prop added to select component.

@GomezIvann GomezIvann self-requested a review January 14, 2025 15:01
@GomezIvann GomezIvann self-assigned this Jan 14, 2025
GomezIvann
GomezIvann suggested changes Jan 15, 2025
View reviewed changes
@GomezIvann GomezIvann merged commit 1173457 into master Jan 15, 2025
3 of 4 checks passed
@GomezIvann GomezIvann deleted the jialecl-select-ariaLabel branch January 15, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GomezIvann GomezIvann GomezIvann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GomezIvann GomezIvann

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jialecl @GomezIvann