Skip to content

Code Quality Update #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PelayoFelgueroso merged 196 commits into from
Sep 30, 2025
Merged

Code Quality Update #2033

PelayoFelgueroso merged 196 commits into from
Sep 30, 2025

Conversation

@Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Jul 8, 2024 •
edited
Loading

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
We want to follow the best practices and achieve a higher code quality by using automatic tools (Husky, Prettier, ESLint and Staged-Lint). This PR contains both the setup of the tools and the fix of most existing code quality issues.

The goal to achieve is to remove all the custom rules existing in the eslint configuration file and pass with no errors and no warnings.

Closes #2031, #2043

Mil4n0r added 30 commits April 9, 2024 13:19
@Mil4n0r
Basic Husky + ESLint + Prettier configuration
5bffdcd
@Mil4n0r
Fixed incorrect values in eslint config
30b4fcf
@Mil4n0r
Fixed TS problems within ESLint
8a04180
@Mil4n0r
Fixed some of the errors detected by eslint
5ce33b2
@Mil4n0r
Converted configuration files to TS
c9b0e19
@Mil4n0r
Added security plugin to ESLint
d32c8e9
@Mil4n0r
Removed unwanted comment
2c0a962
@Mil4n0r
Fixing ESLint detected problems
e424fbc
@Mil4n0r
Fixing ESLint detected problems
9bc889f
@Mil4n0r
Fixing ESLint detected problems
4552df1
@Mil4n0r
Fixing ESLint detected problems
db358cf
@Mil4n0r
Run prettier in the whole src/
ffbb1d7
@Mil4n0r
Fixing ESLint detected problems
4a16152
@Mil4n0r
Moved accessibility files
260206f
@Mil4n0r
Changed tsconfig rootDir
f24aa79
@Mil4n0r
Modified TS config to allow jest configs
5137f2a
@Mil4n0r
Fixed minor bugs after refactoring
f591059
@Mil4n0r
Relocated accessibility config files
a470dbe
@Mil4n0r
Removed rootDir from tsconfig
966289c
@Mil4n0r
Changed mocks from js to ts
9c77af7
@Mil4n0r
Modified certain incorrect default blocks
4e03fce
@Mil4n0r
Fixed checkbox color
26763e3
@Mil4n0r
Minor fixes
e23ffbe
@Mil4n0r
Removed ESLint rule comment
361e606
@Mil4n0r
Removed unexpected end of line
8a6e16c
@Mil4n0r
Fixed key code typo
e5bf87c
@Mil4n0r
Removed unnecessary 'break'
7c795f1
@Mil4n0r
Refactored some if/else blocks
1ff6f24
@Mil4n0r
Refactored certain exports/imports
d2bc8f5
@Mil4n0r
Added pending disabledRule
f05db8f
@Mil4n0r Mil4n0r marked this pull request as draft July 17, 2025 12:32
PelayoFelgueroso
PelayoFelgueroso reviewed Sep 26, 2025
View reviewed changes
PelayoFelgueroso
PelayoFelgueroso reviewed Sep 29, 2025
View reviewed changes
@Mil4n0r Mil4n0r marked this pull request as ready for review September 30, 2025 08:19
@PelayoFelgueroso PelayoFelgueroso merged commit 2545a1f into master Sep 30, 2025
4 checks passed
@PelayoFelgueroso PelayoFelgueroso deleted the Mil4n0r/code_quality_monorepo branch September 30, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PelayoFelgueroso PelayoFelgueroso PelayoFelgueroso approved these changes

Assignees

@PelayoFelgueroso PelayoFelgueroso

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mil4n0r @PelayoFelgueroso