Skip to content

Fix thread safety bug in lazy load pattern #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwolfhub merged 2 commits into from
Oct 6, 2025
Merged

Fix thread safety bug in lazy load pattern #92

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97f3971
Fix thread safety bug in lazy load pattern
musicsnobj Oct 3, 2025
f321026
Merge branch 'master' into feature/fix-thread-safety
musicsnobj Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions zxcvbn/matching.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,9 @@ def get_ranked_dictionaries():
# Do the expensive import here only
from zxcvbn.frequency_lists import FREQUENCY_LISTS

# Build the dictionary once
RANKED_DICTIONARIES = {}
for name, lst in FREQUENCY_LISTS.items():
RANKED_DICTIONARIES[name] = build_ranked_dict(lst)
# Build in local scope before adding to global scope for thread safety
built_dict = {name: build_ranked_dict(lst) for name, lst in FREQUENCY_LISTS.items()}
RANKED_DICTIONARIES = built_dict
return RANKED_DICTIONARIES


Expand Down