Skip to content

Stabilize workflow fixture assertions#362

Merged
rmcdaniel merged 1 commit intomasterfrom
fix/test-flake
Mar 24, 2026
Merged

Stabilize workflow fixture assertions#362
rmcdaniel merged 1 commit intomasterfrom
fix/test-flake

Conversation

@rmcdaniel
Copy link
Member

Summary

  • replace assertion-driven workflow fixture checks with explicit AssertionError guards so test behavior does not depend on PHP assert settings
  • keep the runningInConsole() preconditions explicit in test fixtures instead of letting them disappear when assertions are disabled
  • update WorkflowTest::testCompletedDelay() to expect the deterministic TestWorkflow side-effect log entry

Testing

  • composer feature -- --filter AsyncWorkflowTest
  • vendor/bin/phpunit --testdox --testsuite feature --filter '^Tests\\Feature\\WorkflowTest(::.*)?$'
  • composer unit -- --filter WorkflowStubTest

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (68e47cd) to head (537389f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #362   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       579       579           
===========================================
  Files             62        62           
  Lines           2007      2007           
===========================================
  Hits            2007      2007           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rmcdaniel rmcdaniel merged commit a8f4e97 into master Mar 24, 2026
3 checks passed
@rmcdaniel rmcdaniel deleted the fix/test-flake branch March 24, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants