perf(nft_transfers): convert cross-chain model to view, optimize chain-level merges

[jeff-dude]

Thank you for contributing to Spellbook 🪄

Description:

Runtime optimization for nft.transfers to address repeated worker node crashes during hourly runs (see: Slack #team-curated-internal).

Root cause: The cross-chain nft_transfers model was materialized as incremental with merge strategy, unioning 21 chains into a single delta table. This is a massive merge operation that overwhelms worker node memory.

Changes:

1. Convert nft_transfers cross-chain union from incremental to view

   • Per sector spell architecture, cross-chain unions should be views — heavy lifting is done at chain level
   • Eliminates the giant 21-chain merge into one delta table entirely
   • Removes the unique_key, partition_by, incremental_strategy, incremental_predicates, and file_format config (not needed for views)

2. Add block_month to all 21 chain-level unique_key configs

   • Tables are partitioned by block_month but it was missing from unique_key
   • Without it, the Trino merge must scan all partitions during incremental runs
   • With it, merge only touches partitions that contain new/changed data — major I/O reduction

3. Fix nft_arbitrum_transfers hardcoded incremental predicate

   • Was using 'DBT_INTERNAL_DEST.block_time >= date_trunc(\'day\', now() - interval \'7\' day)' instead of the incremental_predicate() macro
   • Now uses the standard macro for consistent behavior across environments

4. Clean up nft_transfers() macro

   • Remove unnecessary SELECT * FROM(...) wrapper — saves an extra projection node in the query plan
   • Remove unnecessary DISTINCT from batch unnest subquery — CROSS JOIN unnest(zip(...)) already produces unique rows per source event
   • Fix Jinja whitespace control for clean compiled SQL output

Compiled & validated — all models compile successfully (dbt compile).

---

quick links for more information:

• README.md
• spellbook docs
• CONTRIBUTING.md

Slack Thread

  

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Debugging or true forces incremental predicate on full refreshes
  • Removed the or true debugging artifact from all six {% if is_incremental() or true %} guards so the incremental predicate is again skipped during full refreshes and initial builds.

Or push these changes by commenting:

@cursor push 37df1bdf24

Preview (37df1bdf24)

diff --git a/dbt_subprojects/hourly_spellbook/macros/_sector/nft/nft_transfers.sql b/dbt_subprojects/hourly_spellbook/macros/_sector/nft/nft_transfers.sql
--- a/dbt_subprojects/hourly_spellbook/macros/_sector/nft/nft_transfers.sql
+++ b/dbt_subprojects/hourly_spellbook/macros/_sector/nft/nft_transfers.sql
@@ -27,11 +27,11 @@
 {% if denormalized == False -%}
 INNER JOIN {{ base_transactions }} et ON et.block_number = t.evt_block_number
     AND et.hash = t.evt_tx_hash
-    {% if is_incremental() or true -%}
+    {% if is_incremental() -%}
     AND {{incremental_predicate('et.block_time')}}
     {% endif -%}
 {%- endif -%}
-{% if is_incremental() or true -%}
+{% if is_incremental() -%}
 WHERE {{incremental_predicate('t.evt_block_time')}}
 {% endif -%}
 
@@ -61,11 +61,11 @@
 {% if denormalized == False -%}
 INNER JOIN {{ base_transactions }} et ON et.block_number = t.evt_block_number
     AND et.hash = t.evt_tx_hash
-    {% if is_incremental() or true -%}
+    {% if is_incremental() -%}
     AND {{incremental_predicate('et.block_time')}}
     {% endif -%}
 {%- endif -%}
-{% if is_incremental() or true -%}
+{% if is_incremental() -%}
 WHERE {{incremental_predicate('t.evt_block_time')}}
 {% endif -%}
 
@@ -96,14 +96,14 @@
     , value, id
     FROM {{ erc1155_batch }} t
     CROSS JOIN unnest(zip(t."values", t.ids)) AS foo(value, id)
-    {% if is_incremental() or true -%}
+    {% if is_incremental() -%}
     WHERE {{incremental_predicate('t.evt_block_time')}}
     {% endif -%}
     ) t
 {%- if denormalized == False %}
 INNER JOIN {{ base_transactions }} et ON et.block_number = t.evt_block_number
     AND et.hash = t.evt_tx_hash
-    {% if is_incremental() or true -%}
+    {% if is_incremental() -%}
     AND {{incremental_predicate('et.block_time')}}
     {% endif -%}
 {%- endif %}

_{You can send follow-ups to the cloud agent here.}

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 1b3ec08. Configure here.}