CUR2-1212 multichain dex trades clean #9155
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
WIP
Closed
0xBoxer
reviewed
Jan 8, 2026
Collaborator
0xBoxer
left a comment
0xBoxer
left a comment
There was a problem hiding this comment.
Would be great if you can also create a schema.yml file roughly documenting the unions we are making for each of these columns.
choice of columns looks solid to me
alicecha
force-pushed
the
multichain-dex-ttrades-clean
branch
from
e0ce131 to
1146964
Compare
0xBoxer
requested changes
Jan 9, 2026
Collaborator
0xBoxer
left a comment
0xBoxer
left a comment
There was a problem hiding this comment.
What about Sui and TON dex trades, is it too hard to standardise them in here?
Contributor
Author
I looked briefly but need more time to validate the data quality and standardise. Should be doable by dedicating ~1 day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
quick links for more information: