zereox - add monad#9136
Conversation
PR SummaryIntroduce Monad support for 0x by adding v2 trades and settler addresses, wiring them into aggregated fills/trades, and updating schemas/exposures.
Written by Cursor Bugbot for commit 6c17ccb. Configure here. |
|
@jeff-dude could you help get this added when you have a chance? |
thanks for heads up. i have notified our customer support team, they should be reaching out (maybe via TG?), we have a new process to go through dune channels and they will help us prioritize this for you 🙏 |
📝 WalkthroughWalkthroughIntroduces new dbt models for 0x protocol on Monad blockchain, adding zeroex_v2_monad_trades (ERC20 trades through Settler contracts) and zeroex_monad_settler_addresses (authorized settler addresses). Integrates the new trades model into the existing zeroex_api_fills_deduped model and updates associated metadata. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@dbt_subprojects/dex/models/_projects/zeroex/monad/zeroex_monad_settler_addresses.sql`:
- Line 6: unique_key currently lists only 'settler_address' which can cause rows
for different token_id values to be clobbered; update the model's merge key to
be a composite key including both 'settler_address' and 'token_id' (i.e., change
unique_key to include 'token_id' alongside 'settler_address') so incremental
merges preserve separate token rows.
In
`@dbt_subprojects/dex/models/_projects/zeroex/monad/zeroex_v2_monad_trades.sql`:
- Around line 44-46: The query currently uses a wildcard projection ("select *
from trade_details"); replace it by explicitly listing every column from the
trade_details table and prefix each with a table alias (e.g., t.column_name) to
make the output schema explicit and stable for downstream unions; update the
SELECT in zeroex_v2_monad_trades.sql to use a table alias for trade_details
(e.g., FROM trade_details AS t) and enumerate all columns in the desired order
with that alias.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 52e252f1-e4d9-4b57-8bae-03160d412005
⛔ Files ignored due to path filters (1)
dbt_subprojects/dex/seeds/_project/zeroex/zeroex_api_fills_deduped_sample.csvis excluded by!**/*.csv
📒 Files selected for processing (5)
dbt_subprojects/dex/models/_projects/zeroex/monad/zeroex_monad_schema.ymldbt_subprojects/dex/models/_projects/zeroex/monad/zeroex_monad_settler_addresses.sqldbt_subprojects/dex/models/_projects/zeroex/monad/zeroex_v2_monad_trades.sqldbt_subprojects/dex/models/_projects/zeroex/zeroex_api_fills_deduped.sqldbt_subprojects/dex/models/_projects/zeroex/zeroex_schema.yml
Description: