Open
Conversation
Lordfirespeed
requested changes
Jul 16, 2025
| * This component accepts <code>application</code> via props, rather than via | ||
| * <code>useApplicationContext</code>, because it requires the application to already be loaded before being rendered. | ||
| */ | ||
| function travelReimbursmentForm({ application }: { application: Application }) { |
Member
There was a problem hiding this comment.
Suggested change
| function travelReimbursmentForm({ application }: { application: Application }) { | |
| function TravelReimbursmentForm({ application }: { application: Application }) { |
React component names must be named in PascalCase
| }) | ||
|
|
||
| async function onSubmit(values: z.infer<typeof travelReimbursmentFormSchema>): Promise<void> { | ||
| await updateApplication("personal", values) |
Member
There was a problem hiding this comment.
this needs to be removed/replaced with something that creates/updates the travel reimbursement request - it's fine for that function to be a placeholder for now
| </div> | ||
| </div> | ||
| <div className="mt-16 flex justify-center"> | ||
| <FormSubmitButton type="submit">Save Progress</FormSubmitButton> |
Member
There was a problem hiding this comment.
Submit button should probably be more like 'submit travel reimbursement request'
| } | ||
|
|
||
| function TravelReimbursmentFormSkeleton() { | ||
| return <FormSkeleton rows={3} className="mt-2" /> |
Member
There was a problem hiding this comment.
The number of rows in the skeleton should ultimately match the number of fields in the form - the fields in the form will be changing though, so that's okay
| return <TravelReimbursmentFormSkeleton /> | ||
| } | ||
|
|
||
| return <TravelReimbursmentFormSkeleton application={application} /> |
Member
There was a problem hiding this comment.
Once the application is loaded, you should return the actual form component, not just the skeleton
Member
Lordfirespeed
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.