feat: add commit-author for customization#53
feat: add commit-author for customization#53srivatsan0611 wants to merge 6 commits intodsanders11:mainfrom
Conversation
|
Hi @srivatsan0611, thanks for the PR! I'll take a deeper look at this when I get some time. Quick question - does E.g. |
Hi @dsanders11, Thanks for taking a look! Great question about commit-body vs multi-line message. You're absolutely right that multi-line message could work: message: | My reasoning for the separate input was:
But honestly, your approach is simpler and more flexible. Users already know multi-line YAML syntax, and it reduces the API surface, if you prefer that approach. Let me know what you think! |
Yea, I'd prefer to have just one |
Thanks for the feedback @dsanders11 . I have now:
I've still kept a "multi line" test cuz I thought that maybe test ensures that messages containing newlines (like the example above) are correctly passed through to the GitHub API. |
|
hi @dsanders11 just a quick follow up. were you able to go through the PR, would you like me to do something else? |
Summary
This PR adds a new optional input to enhance commit customization:
Changes
commit-authorinput to action.ymlTest Plan