Open
Conversation
Like showBarcodeFromLink/showBarcodeFromSelection, getBarcode replaces the source of an image tag, so rename getBarcode to showBarcode to make this clearer.
Contributor
Author
|
Sorry for all the PRs! It's my fault entirely for not actually looking to see if there's any more work I can do first... |
Owner
|
Don't worry, it's all good :) |
Contributor
Author
|
I think I really am done this time. I can't see any more deduplication/renaming to do in this regard. My next project will be to try to implement a local JS-based generator. I'll open up an issue for this as there are some things I want to ask about that. Sorry for all the bother I caused! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like showBarcodeFromLink/showBarcodeFromSelection, getBarcode replaces
the source of an image tag, so rename getBarcode to showBarcode to
make this clearer.