fix: correctly resolve the installed package version#538
Open
zhouzh1 wants to merge 1 commit intods300:masterfrom
Open
fix: correctly resolve the installed package version#538zhouzh1 wants to merge 1 commit intods300:masterfrom
zhouzh1 wants to merge 1 commit intods300:masterfrom
Conversation
Author
|
Is there anybody can help take a review? @ds300 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In our project, the
react-native-weblib is referenced at two places and the respective version scheme for it is different, one is the^0.19.12, another is the~0.19.12, after installing by theyarncommand, the finalyarn.lockfile includes such a fragment which describes what version of thereact-native-webwe're using, but thepatch-packageseems to be not able to correctly process this kind of structure, finally it resolves the package version to be the^0.19.12, react-native-web@npm:~0.19.12, apparently, it's incorrect and causes the patch procedure to fail.Environment