Conversation
## Problem When the --nested-position option was enabled and annotating fixture files (yml files) with position_in_fixture: "before", a NoMethodError was raised. This occurred because YmlParser does not have the type_map method, which is required by determine_annotation_position to find the most deeply nested class declaration. The error occurred at: ```rb parsed.type_map[name] == :class ``` This was not caught in tests because the integration test had fail_on_error: false, allowing the test to pass even when errors occurred. ## Solution A fallback handling was added to determine_annotation_position for parsers that do not have the type_map method (like YmlParser). When type_map is unavailable, the method falls back to using parsed.starts.first, which is the default behavior for non-nested positioning. This fix ensures that: - Fixture files (yml) can be annotated with nested_position: true without errors - When type_map is unavailable, the behavior gracefully falls back to default positioning - Ruby files (using CustomParser with type_map) continue to work as expected with nested positioning ## Test Coverage - Updated the integration test annotate_collapsed_models_nested_position_spec.rb to use fail_on_error: true to catch errors - Added the be_successfully_executed assertion to explicitly verify that the command completes without errors - The test now properly validates that nested_position works correctly with fixture files refs: drwl#270
drwl
approved these changes
Feb 10, 2026
Owner
drwl
left a comment
There was a problem hiding this comment.
The fix makes sense to me.
Thinking out loud here, I wonder if it's an issue with trying to make the Parser generic without a standard sub class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining everything 🚀
Problem
When the --nested-position option was enabled and annotating fixture files (yml files) with position_in_fixture: "before", a NoMethodError was raised. This occurred because YmlParser does not have the type_map method, which is required by determine_annotation_position to find the most deeply nested class declaration.
The error occurred at:
This was not caught in tests because the integration test had fail_on_error: false, allowing the test to pass even when errors occurred.
Solution
A fallback handling was added to determine_annotation_position for parsers that do not have the type_map method (like YmlParser). When type_map is unavailable, the method falls back to using parsed.starts.first, which is the default behavior for non-nested positioning.
This fix ensures that:
Test Coverage
refs: #270