Alter attributes event - Reroll of pull/95#103
Alter attributes event - Reroll of pull/95#103stesi561 wants to merge 3 commits intodrupalauth:mainfrom
Conversation
Fix style warning:
Immediately return this expression instead of
assigning it to the temporary variable "$attributes".
|
|
I'm guessing to merge you will probably want some test coverage included of this new functionality? I'm not sure if @j4-m is still interested in this work. We have a couple of clients using this functionality so I'm definitely keen to get merged. I can potentially look at adding some test coverage if required. Potentially we could also think about the behaviour of the Event - should we be able to remove attributes or just alter and add new ones. Currently the Event Subscriber can remove attributes. I'm not sure if this is desirable behaviour? Perhaps instead of returning the attributes as set on the event after it returns from dispatch we should merge in the attributes returned? |
|
Hmm. Interesting we now fail. Strange. I think will need to dig into this more. |
2 participants
Adds SetAttributesEvent Event that happens after attributes are created. This allows us to update the attributes in a Drupal Module by subscribing to this event.
Also changes two methods in the Drupal Helper from protected to public so they can be used via the Event Subscriber.
Reroll required due to 6ad28dd which also adds Aliases/Imports in a way that prevents an automatic merge.