fix(MenuLinkUrl): Handle translation of URls#1421
Closed
joaogarin wants to merge 1 commit into
Closed
Conversation
|
Please open issues and pull requests on drupal.org: https://www.drupal.org/project/issues/graphql |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is somewhat related to #809 which adds multilingual support for menu links. That works well, however in our case we are passing the language parameter to the menu, and that seems to not get carried away to the URL.
The label is translated fine but the URL itself (which in our case is not translated in the menu item its just the original URL) is not really picked up..the link is to a node so it should be possible to return the translated URL
Our resolvers look like this :
Getting the menu :
getting the menu items :
Item URL :