Support inline aliases for downloading files#93
Open
deviantintegral wants to merge 2 commits intodrupal-composer:masterfrom
Open
Support inline aliases for downloading files#93deviantintegral wants to merge 2 commits intodrupal-composer:masterfrom
deviantintegral wants to merge 2 commits intodrupal-composer:masterfrom
Conversation
Author
|
It looks like master is failing tests: https://travis-ci.org/drupal-composer/drupal-scaffold/builds |
…affold into allow-inline-alias
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're patching core in a separate repository instead of using composer patches. However, this breaks downloading the scaffold files, as the package version is used directly instead of any aliases. That means that files are attempted to be downloaded from drupal.org with our custom branch or tag, instead of what best corresponds to the fork.
This PR respects the
version as versionsyntax in composer.json for determining what to download.