Skip to content

CI-21342: migrate AWS SDK Go v1 to v2 for ECR service#505

Open
chhawchharia wants to merge 1 commit intodrone-plugins:masterfrom
chhawchharia:CI-21342
Open

CI-21342: migrate AWS SDK Go v1 to v2 for ECR service#505
chhawchharia wants to merge 1 commit intodrone-plugins:masterfrom
chhawchharia:CI-21342

Conversation

@chhawchharia
Copy link

Summary

  • Migrate AWS SDK Go v1 (github.com/aws/aws-sdk-go) to v2 (github.com/aws/aws-sdk-go-v2) for ECR authentication
  • Replace session.NewSession() with config.LoadDefaultConfig(ctx) and ecr.NewFromConfig(cfg)
  • Replace temp-file-based OIDC token handling with in-memory identityToken type
  • Add defensive bounds checks in getAuthInfo for AuthorizationData slice
  • Update error handling to use errors.As with typed exceptions

Test plan

  • go build ./... passes
  • go vet ./... passes
  • go test ./... passes
  • Verify ECR authentication works in CI environment
  • Verify OIDC token flow works without temp file

Made with Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants