Skip to content

refactor(design-system)!: remove deprecated DsChip and DsChipGroup components [AR-53409]#341

Merged
mmurawski-dn merged 8 commits intodrivenets:nextfrom
mmurawski-dn:drivenets/michal/AR-53409-remove-ds-chip
Apr 16, 2026
Merged

refactor(design-system)!: remove deprecated DsChip and DsChipGroup components [AR-53409]#341
mmurawski-dn merged 8 commits intodrivenets:nextfrom
mmurawski-dn:drivenets/michal/AR-53409-remove-ds-chip

Conversation

@mmurawski-dn
Copy link
Copy Markdown
Collaborator

No description provided.

vpolessky-dn
vpolessky-dn previously approved these changes Apr 2, 2026
iromanchuk-dn
iromanchuk-dn previously approved these changes Apr 7, 2026
Comment thread packages/eslint-plugin/src/__tests__/no-deprecated.test.ts Outdated
@mmurawski-dn mmurawski-dn dismissed stale reviews from iromanchuk-dn and vpolessky-dn via 3039410 April 14, 2026 09:53
@mmurawski-dn mmurawski-dn force-pushed the drivenets/michal/AR-53409-remove-ds-chip branch 3 times, most recently from dd850d5 to 1d30c9d Compare April 14, 2026 11:27
StyleShit
StyleShit previously approved these changes Apr 14, 2026
vpolessky-dn
vpolessky-dn previously approved these changes Apr 14, 2026
@mmurawski-dn mmurawski-dn dismissed stale reviews from vpolessky-dn and StyleShit via c14b07e April 14, 2026 12:23
@StyleShit StyleShit changed the title refactor(design-system): remove deprecated DsChip and DsChipGroup components [AR-53409] refactor(design-system)!: remove deprecated DsChip and DsChipGroup components [AR-53409] Apr 15, 2026
@mmurawski-dn mmurawski-dn force-pushed the drivenets/michal/AR-53409-remove-ds-chip branch 2 times, most recently from ec7209f to 5254586 Compare April 15, 2026 08:57
iromanchuk-dn
iromanchuk-dn previously approved these changes Apr 15, 2026
Copy link
Copy Markdown
Member

@StyleShit StyleShit Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh, why did you remove it? these are just tests

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no components, no need for that, right?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we'll have more like these in the future, no?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true 💯 bringing back

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there were some changes in this file on main
please update next from main to ensure there are no any conflicts

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to resolve conclicts after all merges, cause main already conflicts with the next and I can not do anything about it (no permissions to push)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed it
could you check?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 👍

@mmurawski-dn mmurawski-dn force-pushed the drivenets/michal/AR-53409-remove-ds-chip branch from a747b26 to e408d88 Compare April 15, 2026 17:20
@mmurawski-dn mmurawski-dn force-pushed the drivenets/michal/AR-53409-remove-ds-chip branch from e408d88 to 326dd4a Compare April 15, 2026 17:20
@mmurawski-dn mmurawski-dn merged commit d5e7bca into drivenets:next Apr 16, 2026
17 checks passed
StyleShit pushed a commit that referenced this pull request Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants