Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/loose-stamps-study.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@drivenets/design-system': major
'@drivenets/eslint-plugin-design-system': major
---

Remove deprecated component `DsSystemStatus`
Remove deprecation eslint rules for `DsSystemStatus`
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ $color-secondary-default: var(--action-cta3);
$color-secondary-hover: var(--neutral-4);
$color-secondary-disabled: var(--action-disabled);

$color-error-default: var(--system-status-error);
$color-error-default: var(--background-background-negative);
$color-error-hover: var(--utility-error);
$color-error-active: var(--utility-error);
$color-error-disabled: var(--action-disabled);
Expand Down
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, same as #340 (comment)

Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ import DsDrawer from './ds-drawer';
import { DsButton } from '../ds-button';
import { DsTextInput } from '../ds-text-input';
import { DsIcon } from '../ds-icon';
// TODO: Use DsStatusBadge instead.
import { DsSystemStatus } from '../ds-system-status';
import { DsStatusBadge } from '../ds-status-badge';
import styles from './ds-drawer.stories.module.scss';
import { DsTypography } from '../ds-typography';
import type { DsDrawerProps } from './ds-drawer.types';
Expand Down Expand Up @@ -82,7 +81,7 @@ export const Default: Story = {
<>
<DsDrawer.Header>
<DsDrawer.Title>
Default Drawer <DsSystemStatus status="healthy" label="Active" />
Default Drawer <DsStatusBadge status="active" label="Active" />
</DsDrawer.Title>
<div className={styles.headerActions}>
<button className={styles.expand} aria-label="Expand">
Expand Down Expand Up @@ -179,7 +178,7 @@ export const WithTabs: Story = {
<>
<DsDrawer.Header>
<DsDrawer.Title>
Drawer with Tabs <DsSystemStatus status="healthy" label="Active" />
Drawer with Tabs <DsStatusBadge status="active" label="Active" />
</DsDrawer.Title>
<div className={styles.headerActions}>
<button className={styles.expand} aria-label="Expand">
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

10 changes: 0 additions & 10 deletions packages/design-system/src/components/ds-system-status/index.ts

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use '../../../../../styles/root_updated';

.progressInfographic {
width: 100%;
height: 20px;
Expand All @@ -17,15 +19,15 @@
transition: width 0.3s ease-in-out;

&--low {
background-color: var(--system-status-error);
background-color: var(--background-background-negative);
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked Ruth about those colors. If wrong, I will update the next branch with proper values

}

&--medium {
background-color: var(--system-status-info);
background-color: var(--background-background-info-strong);
}

&--high {
background-color: var(--system-status-ok);
background-color: var(--background-background-positive-strong);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@
color: var(--white);

&--single {
background-color: var(--system-status-ok);
background-color: var(--background-background-positive-strong);
}

&--relationship {
background-color: var(--system-status-info);
background-color: var(--background-background-info-strong);
}

&--complicated {
background-color: var(--system-status-error);
background-color: var(--background-background-negative);
}
}

Expand Down Expand Up @@ -328,5 +328,5 @@
}

.destructiveAction {
color: var(--system-status-error);
color: var(--background-background-negative);
}
1 change: 0 additions & 1 deletion packages/design-system/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ export * from './components/ds-smart-tabs';
export * from './components/ds-spinner';
export * from './components/ds-status-badge';
export * from './components/ds-stepper';
export * from './components/ds-system-status';
export * from './components/ds-table';
export * from './components/ds-tabs';
export * from './components/ds-tag';
Expand Down
7 changes: 0 additions & 7 deletions packages/design-system/src/styles/_colors.scss
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,6 @@ $colors: (
action-active-light: #c7d8ff,
action-hover-light: #e0eaff,
action-disabled: #b0b4bf,
// System Status
system-status-ok: #067a00,
system-status-info: #005dcf,
system-status-error: #d70a00,
system-status-alert: #d04d07,
system-status-in-progress: #1513da,
system-status-pending: #8836d6,
// Utility
utility-ok: #d6f5cf,
utility-info: #c4dcff,
Expand Down
1 change: 0 additions & 1 deletion packages/design-system/vitest.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export default defineConfig({
'**/ds-chip/**',
'**/ds-chip-group/**',
'**/ds-date-input/**',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'**/ds-system-status/**',
],
thresholds: {
lines: 90,
Expand Down
11 changes: 0 additions & 11 deletions packages/eslint-plugin/src/__tests__/no-deprecated.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,6 @@ ruleTester.run(
},
);

ruleTester.run('no-deprecated-ds-system-status', plugin.rules['no-deprecated-ds-system-status'], {
valid: ['<DsStatusBadge />'],

invalid: [
{
code: '<DsSystemStatus />',
errors: [{ message: `DsSystemStatus is deprecated. Use DsStatusBadge instead.` }],
},
],
});

ruleTester.run('no-deprecated-ds-chip', plugin.rules['no-deprecated-ds-chip'], {
valid: ['<DsTag />', '<DsTagFilter />'],

Expand Down
6 changes: 0 additions & 6 deletions packages/eslint-plugin/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,6 @@ const eslintPlugin = createPlugin(
message: `Using the 'legacy' design for DsButton is deprecated. Use 'v1.2' instead.`,
},

{
name: 'no-deprecated-ds-system-status',
selector: JSXElement('DsSystemStatus'),
message: `DsSystemStatus is deprecated. Use DsStatusBadge instead.`,
},

{
name: 'no-deprecated-ds-chip',
selector: JSXElement('DsChip'),
Expand Down
Loading