Fixed AI agents missing previously downloaded cache.#2310
Conversation
WalkthroughDocumentation update to AGENTS.md adding guidance for checking cached documentation, project conventions, and fetching external docs before task investigation. Additionally extends critical rules with specific Drupal command preferences for config exports and script execution. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@AGENTS.md`:
- Line 65: Update the rule that currently reads "Never modify `scripts/vortex/`
- use `scripts/custom/` for your scripts" to clarify scope: state that
downstream projects should never modify `scripts/vortex/` and must use
`scripts/custom/`, but for the template repository (e.g., drevops/vortex)
modifications to `scripts/vortex/` are expected and allowed for maintenance;
reference the `scripts/vortex/` and `scripts/custom/` paths and explicitly call
out "template repo (drevops/vortex)" so reviewers understand the exception.
|
|
||
| ## Critical Rules | ||
|
|
||
| - **Never modify** `scripts/vortex/` - use `scripts/custom/` for your scripts |
There was a problem hiding this comment.
Clarify the scripts/vortex/ rule for the template repo.
In the template repository, modifying scripts/vortex/ is expected for maintenance. The current blanket prohibition is misleading here. Consider scoping it to downstream projects instead.
✏️ Suggested wording
-- **Never modify** `scripts/vortex/` - use `scripts/custom/` for your scripts
+- **Downstream projects:** do not modify `scripts/vortex/`; use `scripts/custom/` instead.
+- **Template repo (this repo):** updates to `scripts/vortex/` are allowed for template maintenance.Based on learnings: “The drevops/vortex repository is the template source itself. When reviewing PRs in drevops/vortex, modifications to scripts/vortex/ are expected and correct…”
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@AGENTS.md` at line 65, Update the rule that currently reads "Never modify
`scripts/vortex/` - use `scripts/custom/` for your scripts" to clarify scope:
state that downstream projects should never modify `scripts/vortex/` and must
use `scripts/custom/`, but for the template repository (e.g., drevops/vortex)
modifications to `scripts/vortex/` are expected and allowed for maintenance;
reference the `scripts/vortex/` and `scripts/custom/` paths and explicitly call
out "template repo (drevops/vortex)" so reviewers understand the exception.
|
|
|
|
Summary by CodeRabbit