Skip to content

Comments

[#1219] Skip Lagoon deployment for tag mode#2301

Merged
AlexSkrypnyk merged 1 commit intomainfrom
feature/1219-lagoon-tag-deploy
Feb 17, 2026
Merged

[#1219] Skip Lagoon deployment for tag mode#2301
AlexSkrypnyk merged 1 commit intomainfrom
feature/1219-lagoon-tag-deploy

Conversation

@AlexSkrypnyk
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk commented Feb 17, 2026

Summary

  • When a tag deployment is triggered from CI, the Lagoon deploy script (deploy-lagoon.sh) fails because neither VORTEX_DEPLOY_BRANCH nor VORTEX_DEPLOY_PR is set (or set to a tag name that Lagoon doesn't recognize as a branch)
  • Lagoon does not support tag-based deployments — it deploys based on branches and PRs
  • Added an early exit with success when VORTEX_DEPLOY_MODE=tag, printing an informational skip message
  • Added VORTEX_DEPLOY_MODE variable declaration to the Lagoon deploy script (consistent with how deploy.sh and deploy-artifact.sh handle it)

Closes #1219

Test plan

  • Added BATS unit test: "Tag deployment mode skips Lagoon deployment"
  • All 13 deploy-lagoon.bats tests pass
  • All 17 deploy.bats tests pass

Summary by CodeRabbit

  • New Features

    • Tag-based deployments now gracefully skip Lagoon deployments and exit with a clear status message when tag mode is selected.
    • A configurable deploy mode setting was introduced to control this behavior.
  • Tests

    • Added a unit test verifying tag deployment mode skips Lagoon deployment and reports the expected messages.
  • Documentation

    • Updated deployment docs to describe the new deploy mode option and its effect on Lagoon deployments.

@coderabbitai
Copy link

coderabbitai bot commented Feb 17, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

Added a VORTEX_DEPLOY_MODE check to deploy-lagoon.sh that returns early and succeeds when set to "tag"; added a Bats unit test verifying tag-mode skips the Lagoon deployment; updated docs to list deploy-lagoon.sh as a deployment script option.

Changes

Cohort / File(s) Summary
Deploy script
scripts/vortex/deploy-lagoon.sh
Introduce VORTEX_DEPLOY_MODE (default: "branch") and an early-success exit path when VORTEX_DEPLOY_MODE="tag", logging skip messages and avoiding the Lagoon deployment flow.
Unit test
.vortex/tests/bats/unit/deploy-lagoon.bats
Add Bats test "Tag deployment mode skips Lagoon deployment" that sets VORTEX_DEPLOY_MODE="tag" and asserts the script emits start/skip/finish messages.
Docs
.vortex/docs/content/development/variables.mdx
Update documentation to include scripts/vortex/deploy-lagoon.sh alongside scripts/vortex/deploy.sh for the VORTEX_DEPLOY_MODE/deployment script examples.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested labels

PR: Needs review

Poem

🐰 I sniff the tag upon the breeze,
I hop and skip with gentle ease,
"Lagoon not for tags," I softly say—
A tidy exit, then away. 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: adding logic to skip Lagoon deployment when VORTEX_DEPLOY_MODE is set to 'tag', which directly addresses issue #1219.
Linked Issues check ✅ Passed The PR implements option 1 from issue #1219 by skipping Lagoon deployment for tag mode with a success exit and informational message, fully addressing the core requirement to prevent CI job failures.
Out of Scope Changes check ✅ Passed All changes are directly in scope: deployment logic for tag mode in deploy-lagoon.sh, corresponding BATS unit test, and documentation updates to reflect the new VORTEX_DEPLOY_MODE variable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/1219-lagoon-tag-deploy

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.14%. Comparing base (9af076d) to head (be10c30).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2301      +/-   ##
==========================================
- Coverage   77.69%   77.14%   -0.56%     
==========================================
  Files         117      110       -7     
  Lines        6174     6020     -154     
  Branches       44        0      -44     
==========================================
- Hits         4797     4644     -153     
+ Misses       1377     1376       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/1219-lagoon-tag-deploy branch from ca46e33 to 209619d Compare February 17, 2026 23:04
@AlexSkrypnyk AlexSkrypnyk enabled auto-merge (rebase) February 17, 2026 23:04
@github-actions

This comment has been minimized.

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-02-17 23:10:45

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.65% (177/187)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-02-17 23:14:11

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.65% (177/187)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-02-17 23:14:22

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.65% (177/187)

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/1219-lagoon-tag-deploy branch from 209619d to be10c30 Compare February 17, 2026 23:18
@github-actions
Copy link

Code Coverage Report:
  2026-02-17 23:25:22

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.65% (177/187)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-02-17 23:25:26

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.65% (177/187)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-02-17 23:28:53

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.65% (177/187)

@AlexSkrypnyk
Copy link
Member Author

Code Coverage Report:
  2026-02-17 23:28:56

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.65% (177/187)

@AlexSkrypnyk AlexSkrypnyk merged commit b7dc131 into main Feb 17, 2026
28 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/1219-lagoon-tag-deploy branch February 17, 2026 23:34
@github-project-automation github-project-automation bot moved this from BACKLOG to Release queue in Vortex Feb 17, 2026
@AlexSkrypnyk AlexSkrypnyk added this to the 1.36.0 milestone Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Release queue

Development

Successfully merging this pull request may close these issues.

Triggering tag deployment from CI to Lagoon fails the job

1 participant