Conversation
**Added:** - Added logic to Message.fit to extract and preserve `thinking_blocks` and `reasoning_content` attributes from custom message objects, storing them in the resulting Message's metadata - Introduced tests to verify that Message.fit preserves these fields, handles both together, and ignores them when empty or missing **Changed:** - Updated Message.fit to check for and merge `thinking_blocks` and `reasoning_content` into metadata only when present and non-empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
Message.fitto retainthinking_blocksandreasoning_contentAdded:
Message.fitverifying thatthinking_blocksandreasoning_contentare correctly preserved or ignored as appropriate invarious scenarios -
tests/test_chat.pyChanged:
Message.fitmethod to detect and copythinking_blocksandreasoning_contentfrom input objects into the resultingMessage'smetadata only if they are present and non-empty -
rigging/message.pythinking_blocksandreasoning_contentare not included in metadata, improving message objectcleanliness and consistency
Fixes ENG-3882
Generated Summary
This summary was generated with ❤️ by rigging