fix(ai-red-teaming): save_workflow verification and overwrite detection (ENG-6812)

[rdheekonda]

Summary

Fixes save_workflow reporting success without actually overwriting files, causing AI agents to operate under stale assumptions when workflow scripts fail to write correctly.

• Root cause: pathlib.Path.write_text() can silently fail due to permissions, disk space, file locking, or network filesystem issues
• Impact: AI agents think they wrote new code but file remains unchanged, leading to incorrect behavior and debugging issues
• Solution: Add write verification by reading back content and comparing with expected

Linear: https://linear.app/dreadnode/issue/ENG-6812/save-workflow-reports-success-without-overwriting-existing-files

Changes

• tools/workflows.py: Add content verification logic to save_workflow() function
• scripts/workflow_helper.py: Same verification logic for legacy implementation
• tests/test_workflow_helper.py: Test overwrite detection and content validation scenarios
• capability.yaml: Bump version to 1.4.0 (minor version for significant bug fix)

Verification Logic

# Read existing content (if any) for comparison
existing_content = ""
if filepath.exists():
    try:
        existing_content = filepath.read_text()
    except Exception:
        pass

# Attempt write
try:
    filepath.write_text(code)
except Exception as e:
    return f"Error writing file: {e}"

# Verify write succeeded by reading back
try:
    written_content = filepath.read_text()
    if written_content != code:
        return f"Error: File write incomplete..."
    if existing_content and existing_content == written_content and existing_content != code:
        return f"Warning: File exists but content unchanged..."
except Exception as e:
    return f"Error verifying write: {e}"

Test Coverage

• ✅ Normal file creation and overwrite scenarios
• ✅ Silent write failure detection (mocked scenarios)
• ✅ Partial write detection
• ✅ Content verification edge cases
• ✅ All existing tests continue to pass

Test plan

• Run all existing workflow tests: python -m pytest tests/test_workflow_helper.py -v
• Verify new overwrite detection test passes
• Test both tools/workflows.py and scripts/workflow_helper.py implementations
• Confirm capability version bump to 1.4.0

🤖 Generated with Claude Code