chore: refactor from dn.score#17
Merged
GangGreenTemperTatum merged 1 commit intomainfrom Jun 12, 2025
Merged
Conversation
ENG-2228 AIRTBench harness requires `dreadnode` package refactoring
example reason for failure: https://platform.dreadnode.io/strikes/projects/project-mutiny/01JVH7HZPTMPN9Y6KQQHADYZNK model has an actual successful flag but the run fails when it goes to submit the flag this was an upstream SDK change we did not anticipate scorers being removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactors away from
dn.Scoreinline with the migration guideKey Changes:
dn.Scoreinline with the migration guidehttps://docs.dreadnode.io/strikes/migrations/v1#scores-are-now-metrics
https://github.com/dreadnode/sdk/blob/main/docs/migrations/v1.mdx#:~:text=Scores%20are%20now%20Metrics
Changed:
dn.Scoreinline with the migration guidedreadnodepackageTesting:
here is the run id: https://platform.dreadnode.io/strikes/projects/test/01JXJY1TNHC84SV5VNNKBHDR0P
CC @RobMulla for vis