Initial updates to add tests that cause the failure#52
Open
Initial updates to add tests that cause the failure#52
Conversation
Owner
Author
|
I've had to bite the bullet here and look to add a Unfortunately I still have one unit test failing following my latest changes. Apologies this is taking so long to resolve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress PR to start addressing #47 .... I've added a test to reproduce the problem but haven't been able to add a solution yet that doesn't break other tests. I'll continue to investigate and try to get a good solution that doesn't require breaking changes.