Skip to content

Fix OverflowError when connection_max_idle_ms is 0 or inf #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpkp merged 1 commit into from
Mar 14, 2025
Merged

Fix OverflowError when connection_max_idle_ms is 0 or inf #2538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kafka/client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
from kafka.util import Dict, WeakMethod
# Although this looks unused, it actually monkey-patches socket.socketpair()
# and should be left in as long as we're using socket.socketpair() in this file
from kafka.vendor import socketpair
from kafka.vendor import socketpair # noqa: F401
from kafka.version import __version__

if six.PY2:
Expand Down Expand Up @@ -1184,7 +1184,7 @@ def is_expired(self, conn_id):

def next_check_ms(self):
now = time.time()
if not self.lru_connections:
if not self.lru_connections or self.next_idle_close_check_time == float('inf'):
return float('inf')
elif self.next_idle_close_check_time <= now:
return 0
Expand Down
Loading