Skip to content

[SD-1641] [SD-1662] Fix 'Publication infomation' typo in group_publication_metadata label and Previewer role shouldn't be able to bypass site restriction #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincent-gao merged 2 commits into from
Apr 6, 2026
Merged

[SD-1641] [SD-1662] Fix 'Publication infomation' typo in group_publication_metadata label and Previewer role shouldn't be able to bypass site restriction #758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2104ac1
[SD-1641] Fix 'Publication infomation' typo
vincent-gao Mar 25, 2026
a76891b
[SD-1662] revoke `bypass site restriction`
vincent-gao Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions modules/tide_publication/tide_publication.install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,3 +496,18 @@ function tide_publication_update_10012() {
}
$entity_form_display->save();
}

/**
* Fix 'Publication infomation' typo in group_publication_metadata label.
*/
function tide_publication_update_10013() {
/** @var \Drupal\Core\Entity\Display\EntityFormDisplayInterface $entity_form_display */
$entity_form_display = \Drupal::entityTypeManager()->getStorage('entity_form_display')->load('node.publication.default');
$field_group = $entity_form_display->getThirdPartySettings('field_group');

if (isset($field_group['group_publication_metadata']) && $field_group['group_publication_metadata']['label'] === 'Publication infomation') {
$field_group['group_publication_metadata']['label'] = 'Publication information';
$entity_form_display->setThirdPartySetting('field_group', 'group_publication_metadata', $field_group['group_publication_metadata']);
$entity_form_display->save();
}
}
11 changes: 11 additions & 0 deletions tide_core.install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1382,3 +1382,14 @@ function tide_core_update_10037() {
$tideCoreOperation = new TideCoreOperation();
$tideCoreOperation->assignCkeditorTemplatesPermission();
}

Copy link
Copy Markdown

@anthony-malkoun anthony-malkoun Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in here? We're fixing a couple of things?

Copy link
Copy Markdown
Contributor Author

@vincent-gao vincent-gao Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. @anthony-malkoun , sorry, I forgot to update the title and description.
I have update the PR to include https://digital-vic.atlassian.net/browse/SD-1662

/**
* Revoke 'bypass site restriction' permission from previewer role.
*/
function tide_core_update_10038() {
$role = Role::load('previewer');
if ($role && $role->hasPermission('bypass site restriction')) {
$role->revokePermission('bypass site restriction');
$role->save();
}
}
Loading