chore: dep security audit 2026-05 — patch 6/13 CVEs#16
Open
forkni wants to merge 2 commits into
Open
Conversation
onnx 1.19.1 is pinned by two constraints: 1. modelopt FLOAT4E2M1 support requires onnx >=1.18 (IR 11) 2. onnx 1.21.0 breaks FP8 quantization: the external-data loading rewrite (CVE fixes) corrupts weight initializer values read by modelopt/onnxruntime, producing a negative QDQ scale and triggering assert scale >= 0 in onnxruntime/quantization/quant_utils.py. The 6 path-traversal/symlink CVEs in onnx (1.19.x) require loading untrusted ONNX models — accepted risk for this local pipeline that builds engines from trusted HuggingFace sources only. Safe dep updates applied in venv (idna 3.16, Mako 1.3.12, urllib3 2.7.0, pip 26.1.1) fix 6 of 13 audit CVEs. Installer floor pins tracked in StreamDiffusion-installer repo. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Add _get_spaced_timesteps() to pipeline.py: ports paper Table 2 trailing/ linspace/leading formulas; LCM/TCD schedulers stored timestep_spacing in config but never consumed it in set_timesteps (always linear grid) - Activate spacing override in prepare() gated on _SPACING_SAMPLERS so 'normal' is untouched; override flows through sub_timesteps_tensor to the img2img denoising path - Rekey sampler_config: 'sgm uniform' (space) -> 'sgm_uniform'; add no-op comments for beta/karras (neither LCM nor TCD has karras-sigma logic) - Update Literal hints in pipeline.py + wrapper.py to match new key - Fix unet_step non-SDXL branch: always passed kvo_cache= to UNet, but that kwarg only exists on the TRT UNet; add _check_unet_tensorrt() gate (production always TRT so this was never hit; exposed by acceleration=none) - Fix txt2img_sd_turbo non-SDXL: UNet tuple return was not indexed [0] (same TRT vs PyTorch mismatch, same acceleration=none exposure) - Add examples/txt2img/spacing_compare.py: S=10-30 sweep confirms sgm_uniform is indistinguishable from normal at all production step counts (MSE<=10); ddim/simple produce visible shifts (MSE 30-222) at cost of going off-grid Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pip-auditscansetup.pycomment-onlyChanges
setup.py—onnx==1.19.1comment updated to document:assert scale >= 0inonnxruntime/quantization/quant_utils.py)CVEs fixed (venv already patched)
CVEs deferred
mediapipe<5ceilingInstaller
Security floor pins for idna/Mako/urllib3 committed to
StreamDiffusion-installerrepo (separate PR).Test plan
pip check— no new conflictspip-auditafter-fixes: 13 → 7 CVEs (audit_reports/2026-05-23-after-rollback.md)🤖 Generated with Claude Code