feat(Table): 当表格ShowLineNo属性为true，且表格中有列属性Fixed为true时，FixedLineNoColumn该属性自动为true#8057
Open
Tony-ST0754 wants to merge 1 commit into
Open
feat(Table): 当表格ShowLineNo属性为true，且表格中有列属性Fixed为true时，FixedLineNoColumn该属性自动为true#8057Tony-ST0754 wants to merge 1 commit into
Tony-ST0754 wants to merge 1 commit into
Conversation
…mn该属性自动为true feat(Table): 当表格ShowLineNo属性为true，且表格中有列属性Fixed为true时，FixedLineNoColumn该属性自动为true
|
Thanks for your PR, @Tony-ST0754. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the Table component so that when row numbers are shown and any data column is fixed, the LineNo column automatically becomes fixed (including after state persistence), and clarifies related property documentation. Sequence diagram for automatic LineNo column fixing in Table renderingsequenceDiagram
participant BlazorRenderer
participant Table as TableComponent
participant Column as TableColumn
BlazorRenderer->>Table: RenderContentRow(item)
loop ForEachVisibleColumn
Table->>Column: Access Fixed
alt ShowLineNo && Column.Fixed && !FixedLineNoColumn
Table->>Table: FixedLineNoColumn = Column.Fixed
Table->>Table: StateHasChanged()
end
Table->>BlazorRenderer: RenderContentCell(context)
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The logic that sets
FixedLineNoColumnand callsStateHasChanged()insideRenderContentRowintroduces side effects during rendering and risks unnecessary re-renders or render loops; consider computing this once (e.g., inOnParametersSet/OnAfterRender) based on the column metadata instead of mutating state from within the cell render loop. FixedLineNoColumnis a[Parameter]but is being mutated inside the component; if consumers can set this parameter explicitly, it would be clearer either to treat it as internal state (with a backing field) or to introduce a separate internal flag so the component does not overwrite a value controlled by the parent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The logic that sets `FixedLineNoColumn` and calls `StateHasChanged()` inside `RenderContentRow` introduces side effects during rendering and risks unnecessary re-renders or render loops; consider computing this once (e.g., in `OnParametersSet`/`OnAfterRender`) based on the column metadata instead of mutating state from within the cell render loop.
- `FixedLineNoColumn` is a `[Parameter]` but is being mutated inside the component; if consumers can set this parameter explicitly, it would be clearer either to treat it as internal state (with a backing field) or to introduce a separate internal flag so the component does not overwrite a value controlled by the parent.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8057 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 766 766
Lines 34157 34164 +7
Branches 4697 4698 +1
=========================================
+ Hits 34157 34164 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(Table): 当表格ShowLineNo属性为true，且表格中有列属性Fixed为true时，FixedLineNoColumn该属性自动为true
Link issues
fixes #8056
问题描述 / Problem Description
当表格
ShowLineNo属性为true，且表格中有列属性Fixed为true时，FixedLineNoColumn该属性自动为true，以解决，当Table组件中显示行号，但未指定行号这列FixedLineNoColumn该属性，且默认为false，表格中又存在固定列，导致横向滑动时，左侧固定列会移动解决方案 / Solution
ShowLineNo属性为true时，组件将FixedLineNoColumn属性自动设为true;FixedLineNoColumn属性没有设为true的问题影响范围 / Impact
对老用户无影响
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Automatically fix the table line-number column when other columns are fixed and clarify related persisted state behavior.
New Features:
Enhancements: