Skip to content

Fix issue 11939: [Dark Mode]HelpProvider text color is barely visible#14338

Open
SimonZhao888 wants to merge 1 commit intodotnet:mainfrom
SimonZhao888:fix_issue_11939
Open

Fix issue 11939: [Dark Mode]HelpProvider text color is barely visible#14338
SimonZhao888 wants to merge 1 commit intodotnet:mainfrom
SimonZhao888:fix_issue_11939

Conversation

@SimonZhao888
Copy link
Member

@SimonZhao888 SimonZhao888 commented Mar 2, 2026

Fixes #11939

Proposed changes

  • Modify the clrForeground property of the HH_POPUP struct instance to ensure that the font color of the pop-up help bubble matches the WinForms theme font color.

Customer Impact

  • HelpProvider text color is clearly visible.

Regression?

  • Yes

Risk

  • Min

Screenshots

Before

image image

After

2026-03-02.095343.mp4
2026-03-02.095705.mp4

Test methodology

  • Manually

Test environment(s)

  • 11.0.100-preview.1.26104.118
Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #11939 where the HelpProvider popup text color was barely visible in WinForms dark mode. Previously, clrForeground in the HH_POPUP struct was set to 0xFFFFFFFF (commented as "Ignore" — a "use default" sentinel), which caused the HtmlHelp API to use a default foreground color that didn't adapt to the WinForms theme. The fix replaces this with SystemColors.WindowText, consistent with how clrBackground was already set using SystemColors.Window.

Changes:

  • Replace the clrForeground "ignore" sentinel value in HH_POPUP with SystemColors.WindowText to ensure the popup text color matches the current WinForms theme (including dark mode).

@github-actions github-actions bot added area-DarkMode Issues relating to Dark Mode feature and removed needs-area-label labels Mar 2, 2026
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.31714%. Comparing base (a4d6573) to head (7999788).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #14338         +/-   ##
===================================================
+ Coverage   77.24039%   77.31714%   +0.07674%     
===================================================
  Files           3280        3265         -15     
  Lines         645112      644447        -665     
  Branches       47731       47631        -100     
===================================================
- Hits          498287      498268         -19     
+ Misses        143133      142482        -651     
- Partials        3692        3697          +5     
Flag Coverage Δ
Debug 77.31714% <100.00000%> (+0.07674%) ⬆️
integration 19.14767% <0.00000%> (+0.05449%) ⬆️
production 52.29198% <100.00000%> (+0.11426%) ⬆️
test 97.41580% <ø> (ø)
unit 49.66242% <100.00000%> (+0.10226%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-DarkMode Issues relating to Dark Mode feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dark Mode]HelpProvider text color is barely visible

4 participants