Clean-up: Remove xml headers, copyright notices, use TFM properties, …#321
Open
ViktorHofer wants to merge 1 commit intodotnet:mainfrom
Open
Clean-up: Remove xml headers, copyright notices, use TFM properties, …#321ViktorHofer wants to merge 1 commit intodotnet:mainfrom
ViktorHofer wants to merge 1 commit intodotnet:mainfrom
Conversation
…fix build - Remove unnecessary xml headers from msbuild files - Remove unnecessary copyright headers from msbuild files - Remove unnecessary Publishing.props file as v3 is the default - Use TFM properties instead of hardcoded values (and update to in-support TFMs) - Fix the build due to compiling against newer version of .NET - Style clean-up in project files
tmat
reviewed
Feb 17, 2026
| #if NET | ||
| stream.ReadExactly(_buffer, 0, capacity); | ||
| #else | ||
| stream.Read(_buffer, 0, capacity); |
Member
There was a problem hiding this comment.
yeah we should probably add code similar to https://github.com/dotnet/arcade/pull/15673/changes
Member
|
CI failing with |
Member
Author
|
Merge with latest main now that the Arcade PR is merged. Maybe enable the setting in the admin panel (Update branch button). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fix build