Skip to content

Re-enable C++/CLI, SourceLink C++, and compilation context tests now that VS 2026 Helix images include VCTools#53820

Open
Copilot wants to merge 3 commits intomainfrom
copilot/revert-changes-testing-vctool
Open

Re-enable C++/CLI, SourceLink C++, and compilation context tests now that VS 2026 Helix images include VCTools#53820
Copilot wants to merge 3 commits intomainfrom
copilot/revert-changes-testing-vctool

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 10, 2026

The VS 2026 Helix scout images (windows.amd64.vs2026.pre) have been updated to include the v143 (VS 2022) toolset, unblocking the C++/CLI tests that were skipped in #53789. Additionally, restores the net46 test case in the compilation context tests that was skipped in #53796.

Changes

  • Removed Skip = "https://github.com/dotnet/sdk/issues/53789" from all 14 affected [FullMSBuildOnlyFact] test methods across:
    • GivenThatWeWantToBuildACppCliProject.cs (8 tests)
    • GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs (3 tests)
    • GivenThatWeWantToPackACppCliProject.cs (1 test)
    • GivenThatWeWantToPublishACppCliProject.cs (1 test)
    • SourceLinkTests.csCpp() test (1 test)
  • Restored the commented-out [InlineData("net46", "netstandard1.3", false)] test case in GivenThatWeWantToPreserveCompilationContext.cs (reverting the skip from It_publishes_the_project_with_a_refs_folder_and_correct_deps_file test failure #53796)

@marcpopMSFT marcpopMSFT marked this pull request as ready for review April 10, 2026 23:53
@marcpopMSFT marcpopMSFT requested a review from a team as a code owner April 10, 2026 23:53
Copilot AI review requested due to automatic review settings April 10, 2026 23:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Re-enables previously skipped C++/CLI and SourceLink C++ test coverage now that the VS 2026 Helix images include the required v143 VC toolset (unblocking #53789).

Changes:

  • Removed the issue-based Skip from C++/CLI-related [FullMSBuildOnlyFact] tests across Build/Pack/Publish test suites.
  • Removed the issue-based Skip from the SourceLink C++ test.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishACppCliProject.cs Re-enables the publish/run C++/CLI test by removing the issue-based skip.
test/Microsoft.NET.Pack.Tests/GivenThatWeWantToPackACppCliProject.cs Re-enables the C++/CLI pack test by removing the issue-based skip.
test/Microsoft.NET.Build.Tests/SourceLinkTests.cs Re-enables the SourceLink C++ validation test by removing the issue-based skip.
test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs Re-enables transitive-deps C++/CLI tests by removing the issue-based skip.
test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProject.cs Re-enables C++/CLI build/run and failure-mode tests by removing the issue-based skip.

@marcpopMSFT
Copy link
Copy Markdown
Member

marcpopMSFT commented Apr 15, 2026

dnceng fixed the images for the c++ tests but we have new feailures.

  • Container tests: System.ArgumentException : Invalid digest: sha256:testdigest1234 (Parameter 'Digest') CC @baronfel @lbussell
  • CLI tests: Expected string to be empty, but found "Using launch settings from C:\h\w\C5960A88\t\dotnetSdkTests\zxvc4ivb.2pg\ItUsesLaunchP---6064CB71\Properties\launchSettings.json...". CC @MiYanni
  • new integration tests: added due to incompatible targeted frameworks between the two projects. Review the project you are trying to add and verify that is compatible with the following targets:- net9.0

@MiYanni
Copy link
Copy Markdown
Member

MiYanni commented Apr 15, 2026

@copilot Can you make sure all the tests skipped from these commits are no longer skipped in this PR?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 15, 2026

@copilot Can you make sure all the tests skipped from these commits are no longer skipped in this PR?

Done. Commit 263a41d restores the [InlineData("net46", "netstandard1.3", false)] test case in GivenThatWeWantToPreserveCompilationContext.cs from commit 7f2393d. All three commits (03e9d40, 2d2fd6b, 7f2393d) are now fully reverted in this PR.

Copilot AI changed the title Re-enable C++/CLI and SourceLink C++ tests now that VS 2026 Helix images include VCTools Re-enable C++/CLI, SourceLink C++, and compilation context tests now that VS 2026 Helix images include VCTools Apr 15, 2026
Copilot AI requested a review from MiYanni April 15, 2026 23:23
@marcpopMSFT
Copy link
Copy Markdown
Member

RE the new failures that don't appear to be related to this change, I had copilot make some fixes: #53906

It's still digging into the remaining fixes but I figured I'd start there.

FWIW, I created an empty PR to prove those failures are now in main: #53903

@MiYanni
Copy link
Copy Markdown
Member

MiYanni commented Apr 15, 2026

Files were quite out-of-date, not containing both the OTel and xUnit v3 changes remerged on Monday.

@MiYanni
Copy link
Copy Markdown
Member

MiYanni commented Apr 16, 2026

Looks like the launch settings test error fix was created by @MichaelSimons here: #53905

Copilot AI and others added 2 commits April 17, 2026 13:13
@marcpopMSFT marcpopMSFT force-pushed the copilot/revert-changes-testing-vctool branch from fd093c8 to f2d612b Compare April 17, 2026 20:13
@marcpopMSFT marcpopMSFT requested a review from dsplaisted April 22, 2026 23:15
@marcpopMSFT marcpopMSFT enabled auto-merge April 22, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants