Re-enable C++/CLI, SourceLink C++, and compilation context tests now that VS 2026 Helix images include VCTools#53820
Re-enable C++/CLI, SourceLink C++, and compilation context tests now that VS 2026 Helix images include VCTools#53820
Conversation
There was a problem hiding this comment.
Pull request overview
Re-enables previously skipped C++/CLI and SourceLink C++ test coverage now that the VS 2026 Helix images include the required v143 VC toolset (unblocking #53789).
Changes:
- Removed the issue-based
Skipfrom C++/CLI-related[FullMSBuildOnlyFact]tests across Build/Pack/Publish test suites. - Removed the issue-based
Skipfrom the SourceLink C++ test.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishACppCliProject.cs | Re-enables the publish/run C++/CLI test by removing the issue-based skip. |
| test/Microsoft.NET.Pack.Tests/GivenThatWeWantToPackACppCliProject.cs | Re-enables the C++/CLI pack test by removing the issue-based skip. |
| test/Microsoft.NET.Build.Tests/SourceLinkTests.cs | Re-enables the SourceLink C++ validation test by removing the issue-based skip. |
| test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs | Re-enables transitive-deps C++/CLI tests by removing the issue-based skip. |
| test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProject.cs | Re-enables C++/CLI build/run and failure-mode tests by removing the issue-based skip. |
|
dnceng fixed the images for the c++ tests but we have new feailures.
|
Done. Commit 263a41d restores the |
|
Files were quite out-of-date, not containing both the OTel and xUnit v3 changes remerged on Monday. |
|
Looks like the launch settings test error fix was created by @MichaelSimons here: #53905 |
Agent-Logs-Url: https://github.com/dotnet/sdk/sessions/33b3216b-f350-432d-829d-3015575296e5 Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/sdk/sessions/6aee415a-a0d7-4924-8760-63471c8b6cac Co-authored-by: MiYanni <17788297+MiYanni@users.noreply.github.com>
fd093c8 to
f2d612b
Compare
The VS 2026 Helix scout images (
windows.amd64.vs2026.pre) have been updated to include the v143 (VS 2022) toolset, unblocking the C++/CLI tests that were skipped in #53789. Additionally, restores thenet46test case in the compilation context tests that was skipped in #53796.Changes
Skip = "https://github.com/dotnet/sdk/issues/53789"from all 14 affected[FullMSBuildOnlyFact]test methods across:GivenThatWeWantToBuildACppCliProject.cs(8 tests)GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs(3 tests)GivenThatWeWantToPackACppCliProject.cs(1 test)GivenThatWeWantToPublishACppCliProject.cs(1 test)SourceLinkTests.cs—Cpp()test (1 test)[InlineData("net46", "netstandard1.3", false)]test case inGivenThatWeWantToPreserveCompilationContext.cs(reverting the skip from It_publishes_the_project_with_a_refs_folder_and_correct_deps_file test failure #53796)